Keep softness when widening unions #14399
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hard unions are union types explicitly written by the user, while soft unions are created by the compiler (for example as the result of a condition or a match). The former should not be widened, while the later should. Currently, this does not work if the union's operands are singletons because the union looses its "hardness" qualification. This PR fixes it.
Before:
After:
#14347 and #14360 are linked but have a wider scope: avoiding to widen explicit singleton types altogether. But these are not conclusive yet.