Set zero span for synthetic enum import selector #14498

tgodzik · 2022-02-16T15:56:13Z

Fixes #11683

smarter

Otherwise LGTM but it would be nice to leave a documentation comment mentioning why we special-case positions here.

compiler/src/dotty/tools/dotc/ast/Desugar.scala

Fixes scala#11683

tgodzik requested review from smarter and bishabosha February 16, 2022 15:56

tgodzik force-pushed the fix-11683 branch 2 times, most recently from 75946a5 to 9228644 Compare February 17, 2022 10:11

smarter approved these changes Feb 17, 2022

View reviewed changes

compiler/src/dotty/tools/dotc/ast/Desugar.scala Outdated Show resolved Hide resolved

compiler/src/dotty/tools/dotc/ast/Desugar.scala Outdated Show resolved Hide resolved

compiler/src/dotty/tools/dotc/ast/Desugar.scala Outdated Show resolved Hide resolved

smarter assigned tgodzik Feb 17, 2022

tgodzik force-pushed the fix-11683 branch from 9228644 to 1a5ef02 Compare February 17, 2022 12:42

Set zero span for synthetic enum import selector

d473dc4

Fixes scala#11683

tgodzik force-pushed the fix-11683 branch from 1a5ef02 to d473dc4 Compare February 17, 2022 12:47

tgodzik merged commit e492f7a into scala:main Feb 17, 2022

tgodzik deleted the fix-11683 branch February 17, 2022 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set zero span for synthetic enum import selector #14498

Set zero span for synthetic enum import selector #14498

tgodzik commented Feb 16, 2022

smarter left a comment

Set zero span for synthetic enum import selector #14498

Set zero span for synthetic enum import selector #14498

Conversation

tgodzik commented Feb 16, 2022

smarter left a comment

Choose a reason for hiding this comment