improvement(repl): end marker now has the same color as its definition in repl (fix #14535) #14555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking care of this @ireina7! Gentle ping to get this reviewed since it looks good to me and has been sitting now for a couple weeks. |
ckipp01
reviewed
Mar 9, 2022
| @@ -107,9 +107,11 @@ object SyntaxHighlighting { | |||
| case tree: ValOrDefDef => | |||
| highlightAnnotations(tree) | |||
| highlightPosition(tree.nameSpan, ValDefColor) | |||
| highlightPosition(tree.endSpan, ValDefColor) | |||
There was a problem hiding this comment.
Could we add a test in SyntaxHighlightingTests.scala with a test using an end to test this?
|
I added some tests @ckipp01 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we fixed issue #14535 for repl improvement.
Now end markers in definitions of
val,defand various kinds of types have the same color as its definition name.EnumexampleBefore
Now