Handle SummonFrom in reflect TreeAccumulator #14809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print the tree extractors of the reflection API instead of the underlying case class toString.
* Add SummonFrom case * Fix bug with PackageClause case * Complete ClassDef case
smarter
approved these changes
Mar 30, 2022
| val constructor @ DefDef(_, _, _, _) = transformStatement(tree.constructor)(tree.symbol) | ||
| val parents = tree.parents.map(transformTree(_)(tree.symbol)) | ||
| val body = tree.body.map(transformStatement(_)(tree.symbol)) | ||
| ClassDef.copy(tree)(tree.name, constructor, parents, tree.self, body) |
There was a problem hiding this comment.
Any reason tree.self isn't transformed? It's transformed in the compiler TreeMap: https://github.com/lampepfl/dotty/blob/e8356687e294d8a6274c1decf271fbcc43275e5a/compiler/src/dotty/tools/dotc/ast/Trees.scala#L1468
There was a problem hiding this comment.
Missed it. Added.
smarter
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SummonFrom can never be seen from macros as they are always evaluated away before expanding the macro. This can be seen if an inline tree definition is loaded and traversed as is the case with the TastyInspector.
Fixes #14789