Command line parser respects outer escaped quote #15497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
reviewed
Jun 22, 2022
| inline def quote() = { qpos += pos ; bump() } | ||
| cur match | ||
| def advance(): Boolean = cur match |
There was a problem hiding this comment.
could advance be a separate loop called before the wider pattern match? then skipToDelim will continue to be tailrec.
som-snytt
force-pushed
the
forward/command-tokener
branch
from
b174eff
to
2277b6b
Compare
|
In sober light of morning, added comments and corrected loopiness of |
som-snytt
force-pushed
the
forward/command-tokener
branch
from
2277b6b
to
3a851c3
Compare
bishabosha
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port scala/scala#10057
This is the tokenizing utility, not the arg conversion support for main methods.