Ignore types in macro runtime dependencies #15529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How I fixed it: #12498 (comment) |
dwijnand
reviewed
Jun 27, 2022
nicolasstucki
force-pushed
the
fix-#12498
branch
from
306f55b
to
cb208bf
Compare
nicolasstucki
force-pushed
the
fix-#12498
branch
2 times, most recently
from
0b6d5b5
to
6636a6d
Compare
|
Squashed and rebased |
nicolasstucki
changed the title
We can have different kinds of type references in the contents of a splice. We do not care about types because those are erased and the interpreter emulates erased semantics. These types are in `Tree`s that extend `TypeTree` or `RefTree` referring to type. Fixes scala#12498
|
@dwijnand something broke when I rebased. Now it is fixed. Could you double-check the code? |
dwijnand
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can have different kinds of type references in the contents of a
splice. We do not care about types because those are erased and the
interpreter emulates erased semantics. These types are in
Trees thatextend
TypeTreeorRefTreereferring to type.Fixes #12498