Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid leaking internal types in GadtConstraint.approximation #15558

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Avoid leaking internal types in GadtConstraint.approximation #15558

merged 1 commit into from
Jun 30, 2022

Conversation

Linyxus
Copy link
Contributor

@Linyxus Linyxus commented Jun 30, 2022 •
edited
Loading

This PR fixes #15531, where internal type parameters in the GADT solver are leaked by GadtConstraint.approximation.

Now we apply externalize on the result when it is a TypeParamRef to avoid the leaking.

Picked from #15533

@Linyxus Linyxus mentioned this pull request Jun 30, 2022
Closed
@Linyxus Linyxus requested a review from dwijnand June 30, 2022 15:40
@dwijnand dwijnand merged commit fad3175 into scala:main Jun 30, 2022
@Kordyjan Kordyjan added this to the 3.2.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

Leaking internal type parameter reference in GADT casting
3 participants
@Linyxus @dwijnand @Kordyjan