Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #15374: Make sure prefix of outer select has the correct class symbol #15592

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

liufengyun
Copy link
Contributor

@liufengyun liufengyun commented Jul 5, 2022

Fix #15374: Make sure prefix of outer select has the correct class symbol

If we have an outer select e.outer_<hops>, we must make sure that the class symbol
of e is the class where the outer this is located in. Otherwise, the phase
ElimOuterSelect would get confused.

Co-authored-by: Dale Wijnand dale.wijnand@gmail.com

liufengyun and others added 2 commits July 5, 2022 22:31
…ss symbol

If we have an outer select `e.outer_<hops>`, we must make sure that the class symbol
of `e` is the class where the outer this is located in. Otherwise, the phase
`ElimOuterSelect` would get confused.

Co-authored-by: Dale Wijnand <dale.wijnand@gmail.com>
@liufengyun liufengyun marked this pull request as ready for review July 5, 2022 20:52
@liufengyun liufengyun requested a review from odersky July 6, 2022 08:25
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice fix.

@odersky odersky merged commit 6a62bb7 into scala:main Jul 6, 2022
@odersky odersky deleted the fix-15374 branch July 6, 2022 10:15
@Kordyjan Kordyjan added this to the 3.2.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add inline changes semantics
3 participants