Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #15465: Use resolveThis for outerSelect resolution #15606

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Fix #15465: Use resolveThis for outerSelect resolution #15606

merged 2 commits into from
Jul 7, 2022

Conversation

liufengyun
Copy link
Contributor

@liufengyun liufengyun commented Jul 6, 2022 •
edited
Loading

Fix #15465: Use resolveThis for outerSelect resolution

This shows that hops is redundant after #15592. The refactoring can be addressed in another PR.

@liufengyun liufengyun changed the title Fix #15465: Use resolveThis for outer this resolution Fix #15465: Use resolveThis for outerSelect resolution Jul 6, 2022
@liufengyun liufengyun marked this pull request as ready for review July 7, 2022 05:25
olhotak
olhotak approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@olhotak olhotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I especially like that #15592 enables us to remove the complexity of resolveOuterSelect.

@liufengyun liufengyun merged commit ae83f76 into scala:main Jul 7, 2022
@liufengyun liufengyun deleted the fix-15465 branch July 7, 2022 21:54
@nicolasstucki nicolasstucki mentioned this pull request Jul 8, 2022
Closed
@nicolasstucki
Copy link
Contributor

This PR caused a regression: #15618

@Kordyjan Kordyjan added this to the 3.2.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olhotak olhotak olhotak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

Internal error with initialization check
4 participants
@liufengyun @nicolasstucki @olhotak @Kordyjan