Allow refineUsingParent to infer GADT bounds #15706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
force-pushed
the
one-tparam-used-twice
branch
from
746f50b
to
d9659a9
Compare
dwijnand
changed the title
dwijnand
force-pushed
the
one-tparam-used-twice
branch
from
d9659a9
to
b1c07b4
Compare
Not doing so makes the type var interpolation between typer and the match space analysis different, which can result in false positive and negative exhaustivity and reachability warnings
dwijnand
force-pushed
the
one-tparam-used-twice
branch
from
b1c07b4
to
531bf4d
Compare
dwijnand
commented
Jul 26, 2022
All credit to Linyxus!
abgruszecki
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
LGTM! It makes total sense to retract GADT bounds right at the point we try to record them; I knew that there has to be some problem with us not retracting the bounds if they become absurd, but I never quite got to tracing it down and fixing the situation. Nice job with tracing it down, @Linyxus!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not doing so makes the type var interpolation between typer and the match space analysis different, which can result in false positive and negative exhaustivity and reachability warnings.