Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't capture wildcards if in closure or by-name #16732

Merged
merged 3 commits into from
Jan 24, 2023

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Jan 19, 2023

@dwijnand dwijnand requested a review from odersky January 20, 2023 12:43
@dwijnand dwijnand marked this pull request as ready for review January 20, 2023 12:43
@dwijnand
Copy link
Member Author

@odersky looking for any advice on perhaps a better place to do this - it's a shame to have to do it in two places. Also it's doing it post-adapt, though that isn't unheard of. Also, wasn't sure what to put in the error message 😄

@odersky odersky assigned dwijnand and unassigned odersky Jan 23, 2023
@dwijnand dwijnand assigned odersky and unassigned dwijnand Jan 24, 2023
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odersky odersky merged commit 9f1d4b6 into scala:main Jan 24, 2023
@dwijnand dwijnand deleted the capture-wildcard-on-nesting branch January 24, 2023 15:14
@Kordyjan Kordyjan added this to the 3.3.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wildcard capture goes wrong on nested wildcard
3 participants