Map class literal constant types #16988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
force-pushed
the
avoid-constant-types
branch
from
97cd4a8
to
7b234f1
Compare
smarter
requested changes
Feb 22, 2023
dwijnand
force-pushed
the
avoid-constant-types
branch
from
7b234f1
to
92118c4
Compare
dwijnand
changed the title
dwijnand
commented
Feb 24, 2023
| case ast.TreeInfo.Impure => "PurityLevel.Impure" | ||
| case ast.TreeInfo.PurePath => "PurityLevel.PurePath" | ||
| case ast.TreeInfo.IdempotentPath => "PurityLevel.IdempotentPath" | ||
| case _ => s"PurityLevel(${x.x})" |
There was a problem hiding this comment.
I was looking at
val countsAsPure =
if dropOp(tree1).symbol.isInlineVal
then isIdempotentExpr(tree1)
else isPureExpr(tree1)in constToLiteral and needed to print purity levels.
There was a problem hiding this comment.
Could this be achieved by making PurityLevel an enum instead to generate a sensible toString?
There was a problem hiding this comment.
Perhaps. But what's a nice way to reimplement min?
There was a problem hiding this comment.
Ah I hadn't considered that, nevermind then.
There was a problem hiding this comment.
This could still be implemented as the toString of PurityLevel since it doesn't require a Context.
dwijnand
changed the title
smarter
approved these changes
Feb 24, 2023
| case ast.TreeInfo.Impure => "PurityLevel.Impure" | ||
| case ast.TreeInfo.PurePath => "PurityLevel.PurePath" | ||
| case ast.TreeInfo.IdempotentPath => "PurityLevel.IdempotentPath" | ||
| case _ => s"PurityLevel(${x.x})" |
There was a problem hiding this comment.
Could this be achieved by making PurityLevel an enum instead to generate a sensible toString?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16954