Enrich and finesse compiler crash reporting #17031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a good core of uncontroversial (I think) yet highly beneficial changes to land. Perhaps some of the rest of #16685 and/or #16593 could eventually land as separate followup PRs. cc @robmwalsh |
odersky
approved these changes
Mar 6, 2023
odersky
requested changes
Mar 6, 2023
Having a same-named enrichement will cause the original to be called if/when explicit nulls is switched off - which leads to the original method to be called, meaning an NPE will be thrown. So, instead, move all the functionality as an extension method, so we don't need mangled names.
odersky
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the changes from #16685.