Fix references to class members defined in quotes #17107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-17103
branch
from
ec65eb3
to
6a24cdf
Compare
If an inner quote selects a symbol that is defined in an outer quote we need to transform it or reject it. The issue is that the inner quote cannot contain a reference to the type of the class defined in the outer quote. Any such reference is erased the parents of that class that are statically know outside those quotes. If the selected symbol is overriding a symbol in one of those statically known classes, we can use that overridden symbol instead. If not we have to reject the code. Fixes scala#17103
nicolasstucki
force-pushed
the
fix-17103
branch
from
6a24cdf
to
2d1ef63
Compare
natsukagami
approved these changes
Mar 18, 2023
| @@ -208,6 +208,14 @@ class Splicing extends MacroTransform: | |||
|
|
|||
| override def transform(tree: tpd.Tree)(using Context): tpd.Tree = | |||
| tree match | |||
| case tree: Select if tree.isTerm && isCaptured(tree.symbol) => | |||
| tree.symbol.allOverriddenSymbols.find(sym => !isCaptured(sym.owner)) match | |||
There was a problem hiding this comment.
Does it matter if there are multiple overridden symbols that are not captured? I think it doesn't but just want to make sure.
There was a problem hiding this comment.
It should no matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an inner quote selects a symbol that is defined in an outer quote we need to transform it or reject it. The issue is that the inner quote cannot contain a reference to the type of the class defined in the outer quote. Any such reference is erased the parents of that class that are statically know outside those quotes. If the selected symbol is overriding a symbol in one of those statically known classes, we can use that overridden symbol instead. If not we have to reject the code.
Fixes #17103