Do not issue deprecation warnings when declaring deprecated case classes #17165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-pieter
commented
Mar 28, 2023
jan-pieter
changed the title
odersky
requested changes
Apr 24, 2023
| def skipWarning(using Context) = | ||
| ctx.owner.ownersIterator.exists(if sym.isEnumCase then isDeprecatedOrEnum else _.isDeprecated) | ||
| def skipWarning(using Context): Boolean = | ||
| (ctx.owner.is(Synthetic) && sym.is(CaseClass)) || |
There was a problem hiding this comment.
The preferred style is to move || in front of next line.
odersky
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do trigger a deprecation warning when calling synthetic members of the companion object of a deprecated case class.
Fixes #11022