Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Modify the CSS so that the logo of the generated documentation is adaptive #17172

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Fix: Modify the CSS so that the logo of the generated documentation is adaptive #17172

merged 1 commit into from
Apr 12, 2023

Conversation

Dedelweiss
Copy link
Contributor

  • Add a fixed width of the span
  • Add a 100% for the img in the span

Before:

Screenshot 2023-03-29 at 15 18 30

After:

Screenshot 2023-03-29 at 15 18 19

Fixes: #17171

@Dedelweiss Dedelweiss changed the title Fix: Change the CSS the logo for the generated documentation is adaptive Fix: Modify the CSS so that the logo of the generated documentation is adaptive Mar 29, 2023
Florian3k
Florian3k requested changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@Florian3k Florian3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding those changes causes logo to be too high in some cases (when logo is more narrow, such as Scala logo):
image
Can we change it to use height/max-height (and possibly add some max-width in case someone uses really wide logo)?

@Dedelweiss
Copy link
Contributor Author

Can we change it to use height/max-height (and possibly add some max-width in case someone uses really wide logo)?

Would you like to set the max-height in .logo-container .project-logo img ? Because I'm not sure if it has much impact. According to my tests, a max-width is enough.

@Dedelweiss Dedelweiss force-pushed the logo_adaptive branch 2 times, most recently from bfcc754 to 1502de2 Compare April 5, 2023 14:44
@Dedelweiss
Change the CSS the logo for the generated documentation is adaptive
25d1b63 
- Add a fixed width of the span
- Add a 100% for the img in the span
@Dedelweiss
Copy link
Contributor Author

Done, thank you for the feedback @Florian3k !

@Florian3k Florian3k merged commit 2297d25 into scala:main Apr 12, 2023
@Dedelweiss Dedelweiss deleted the logo_adaptive branch April 13, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Florian3k Florian3k Florian3k approved these changes

Assignees

@Florian3k Florian3k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The size of the -project-logo is not adaptive
2 participants
@Dedelweiss @Florian3k