correctly type Expr.ofTupleFromSeq for arity > 22 #17261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
force-pushed
the
fix-oftuplefromseq
branch
from
53dfd1e
to
49d9901
Compare
dwijnand
approved these changes
Apr 14, 2023
|
Also seeing the same failure here: |
|
Looks like a semantic merge conflict on the Wunused merges? @szymon-rd wdyt? |
|
Ah yeah, #17263 |
|
@bishabosha also take into account #17257 (comment) |
|
@nicolasstucki I added a test for |
nicolasstucki
approved these changes
Apr 17, 2023
|
could this be backported for 3.3.1 ? |
xuwei-k
reviewed
Oct 16, 2024
| private def tupleTypeFromSeq(seq: Seq[Expr[Any]])(using Quotes): quotes.reflect.TypeRepr = | ||
| import quotes.reflect.* | ||
| val consRef = Symbol.classSymbol("scala.*:").typeRef | ||
| seq.foldLeft(TypeRepr.of[EmptyTuple]) { (ts, expr) => |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
identified that for all
Seqwith arity <= 22, the result had the most precise type possible, for > 22 then it was onlyTuplefixes #17257