Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contextual varargs parameters #18186

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Contextual varargs parameters #18186

merged 1 commit into from
Jul 13, 2023

Conversation

iusildra
Copy link
Contributor

fixes #18090

@iusildra iusildra marked this pull request as ready for review July 12, 2023 08:18
nicolasstucki
nicolasstucki reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@nicolasstucki
Copy link
Contributor

@iusildra could you squash the commits?

@iusildra
added check for repeated params in using clause
d36bb52 
refactor and more tests

Update error message

Co-authored-by: Nicolas Stucki <nicolas.stucki@gmail.com>

fix error code
@nicolasstucki nicolasstucki merged commit bc2527e into scala:main Jul 13, 2023
@Kordyjan Kordyjan added this to the 3.4.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Contextual vararg parameters
3 participants
@iusildra @nicolasstucki @Kordyjan