Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make check flags for newMethod, newVal and newBind in Quotes API less restrictive #18217

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Make check flags for newMethod, newVal and newBind in Quotes API less restrictive #18217

merged 2 commits into from
Oct 17, 2023

Conversation

pweisenburger
Copy link
Contributor

Fixes #17764

Allows Flags.Artifact and Flags.Synthetic and the other "flags that could be allowed" as they are valid flags and there is no reason to forbid them.

nicolasstucki
nicolasstucki suggested changes Jul 17, 2023
View reviewed changes
compiler/src/scala/quoted/runtime/impl/QuotesImpl.scala Outdated Show resolved Hide resolved
library/src/scala/quoted/Quotes.scala Outdated Show resolved Hide resolved
compiler/src/scala/quoted/runtime/impl/QuotesImpl.scala Outdated Show resolved Hide resolved
compiler/src/scala/quoted/runtime/impl/QuotesImpl.scala Outdated Show resolved Hide resolved
library/src/scala/quoted/Quotes.scala Outdated Show resolved Hide resolved
library/src/scala/quoted/Quotes.scala Outdated Show resolved Hide resolved
@nicolasstucki
Copy link
Contributor

other "flags that could be allowed" as they are valid flags and there is no reason to forbid them

The reason they are not allowed is because they are not supported. Adding them could break soundness without support in the compiler could break soundness.

@nicolasstucki nicolasstucki self-assigned this Jul 17, 2023
@nicolasstucki nicolasstucki merged commit b90e9c6 into scala:main Oct 17, 2023
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 21, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 22, 2024
@WojciechMazur
Backport "Make check flags for newMethod, newVal and newBind in…
75c564b 
… Quotes API less restrictive" to LTS (#20719)

Backports #18217 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Checking flags for new symbols using Quotes API is too restrictive
3 participants
@pweisenburger @nicolasstucki @Kordyjan