Keep tree of type ascriptions of quote pattern splices #18412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-18409
branch
3 times, most recently
from
990faff
to
c34c741
Compare
These trees where removed as part of an optimization. However, they should be kept around to allow for better error messages and IDE navigation. The type of the ascription in pickled in the TASTy file but is elided in the pickled quote pattern (same optimization already done later). Fixes scala#18409
nicolasstucki
force-pushed
the
fix-18409
branch
from
c34c741
to
f02befc
Compare
nicolasstucki
added
the
backport:nominated
nicolasstucki
commented
Aug 17, 2023
| super.transform(tree) | ||
| case tree: SplicePattern => | ||
| if !ctx.reporter.errorsReported then | ||
| Checking.checkAppliedTypesIn(TypeTree(tree.tpe).withSpan(tree.span)) |
There was a problem hiding this comment.
This was a workaround that we added to check the types of the splices because we removed them in QuotesAndSplices. Now those types are checked directly on their ASTs.
Kordyjan
removed
the
backport:nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These trees where removed as part of an optimization. However, they should be kept around to allow for better error messages and IDE navigation.
The type of the ascription in pickled in the TASTy file but is elided in the pickled quote pattern (same optimization already done later).
Fixes #18409