Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honour hard unions in lubbing and param replacing #18680

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Honour hard unions in lubbing and param replacing #18680

merged 3 commits into from
Nov 13, 2023

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Oct 12, 2023 •
edited
Loading

No description provided.

@dwijnand dwijnand linked an issue Oct 12, 2023 that may be closed by this pull request
Type inference doesn't work correctly for union types used with extension method #18626
Closed
@dwijnand dwijnand marked this pull request as ready for review October 12, 2023 17:10
@dwijnand dwijnand requested a review from odersky October 12, 2023 17:10
odersky
odersky approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! Nevertheless, I'd like to ask @smarter for a second opinion.

@odersky odersky assigned smarter and unassigned odersky Nov 10, 2023
smarter
smarter approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@smarter smarter merged commit 41279ac into scala:main Nov 13, 2023
18 checks passed
@dwijnand dwijnand deleted the no-widen-hard-union branch November 13, 2023 11:45
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

@smarter smarter smarter approved these changes

Assignees

@smarter smarter

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Type inference doesn't work correctly for union types used with extension method
4 participants
@dwijnand @smarter @odersky @Kordyjan