bugfix: Completions for named args in wrong order #18702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochala
requested changes
Oct 17, 2023
| * ) | ||
| * In this case, typed path doesn't contain already provided arguments | ||
| */ | ||
| NavigateAST.untypedPath(pos.span) match |
There was a problem hiding this comment.
Untyped path is already computed for the completions. We shouldn't recompute it. Check for
val adjustedPath = Completion.resolveTypedOrUntypedPath(path, pos)
jkciesluk
force-pushed
the
named-wrong-order
branch
from
2849c1f
to
12050ae
Compare
jkciesluk
force-pushed
the
named-wrong-order
branch
from
12050ae
to
5179962
Compare
jkciesluk
force-pushed
the
named-wrong-order
branch
from
5179962
to
052c2e2
Compare
rochala
approved these changes
Nov 10, 2023
WojciechMazur
pushed a commit
that referenced
this pull request
Jun 27, 2024
connected to scalameta/metals#5728 [Cherry-picked b9cd807]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connected to scalameta/metals#5728