-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation warnings for old syntax: private[this]
#18819
Deprecation warnings for old syntax: private[this]
#18819
Conversation
73f63c8
to
96f88a0
Compare
private[this]
a migration warningprivate[this]
private[this]
private[this]
private[this]
private[this]
b2e7a55
to
3717e1a
Compare
private[this]
private[this]
)
private[this]
)private[this]
c5167ae
to
5c795df
Compare
db84c48
to
b676153
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but this is going to be a problem for code that cross-compiles with Scala 2 where private[this]
might be needed to avoid variance errors. I wish we had a flag to silence all warnings that can prevent cross-compilation.
The consensus what that that flag would be |
OK, something we'll have to make sure is well communicated then. |
b676153
to
4b01f58
Compare
Also, if you cross-compile, it means you care about your users being able to use older versions of the compiler. Presumably that includes Scala 3.3.x LTS users. So in fact you should keep compiling with 3.3.x and not upgrade to 3.4+. |
I said the same thing at the Dotty meeting yesterday :-) So yeah, the crew is aware. |
This should also be mentioned in the release notes |
* In `3.4` we emit the deprecation warning and enable the patch with -rewrite. * In `future` we emit we make this syntax an error
4b01f58
to
a0699ae
Compare
This is the first part of #18863
3.4
we emit the deprecation warning and enable the patch with -rewrite.future
we emit we make this syntax an error