Avoid crashes on missing positions #19250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All positions should be set on these trees and symbols at this point. If one is missing it is due to a compiler bug. We default the position to 0 if there is a missing position to avoid crashing when calling methods on Position. To make it possible for us to fix these missing positions, we warn if there is a missing position when compiling with -Xcheck-macros.
nicolasstucki
force-pushed
the
avoid-crashes-with-missing-positions
branch
from
dcbf416
to
8d5a04c
Compare
nicolasstucki
added
the
backport:nominated
dwijnand
approved these changes
Dec 13, 2023
WojciechMazur
added a commit
that referenced
this pull request
Jun 26, 2024
Backports #19250 to the LTS branch. PR submitted by the release tooling. [skip ci]
WojciechMazur
removed
the
backport:nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All positions should be set on these trees and symbols at this point. If one is missing it is due to a compiler bug. We default the position to 0 if there is a missing position to avoid crashing when calling methods on Position. To make it possible for us to fix these missing positions, we warn if there is a missing position when compiling with -Xcheck-macros.