Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodalAssert.cpp:26:5: error: 'codal_dmesg_flush' was not declared in this scope #365

Closed
martinwork opened this issue Aug 10, 2023 · 3 comments
Assignees
Labels
Milestone

Comments

@martinwork
Copy link
Collaborator

These errors stop current master branches building when DMESG is not enabled.

../libraries/codal-core/source/core/CodalAssert.cpp: In function 'void __codal_assert__(const char*, int, bool, const char*, const char*)':
../libraries/codal-core/source/core/CodalAssert.cpp:26:5: error: 'codal_dmesg_flush' was not declared in this scope
   26 |     codal_dmesg_flush();
      |     ^~~~~~~~~~~~~~~~~
../libraries/codal-core/source/core/CodalAssert.cpp: In function 'void __codal_fault__(const char*, int, const char*)':
../libraries/codal-core/source/core/CodalAssert.cpp:38:5: error: 'codal_dmesg_flush' was not declared in this scope
   38 |     codal_dmesg_flush();
      |     ^~~~~~~~~~~~~~~~~
../libraries/codal-core/source/core/CodalAssert.cpp: In function 'void __codal_assert_pass__(const char*, int, const char*)':
../libraries/codal-core/source/core/CodalAssert.cpp:48:5: error: 'codal_dmesg_flush' was not declared in this scope
   48 |     codal_dmesg_flush();
      |     ^~~~~~~~~~~~~~~~~
../libraries/codal-core/source/core/CodalAssert.cpp: In function 'void __codal_assert_fail__(const char*, int, const char*)':
../libraries/codal-core/source/core/CodalAssert.cpp:63:5: error: 'codal_dmesg_flush' was not declared in this scope
   63 |     codal_dmesg_flush();
      |     ^~~~~~~~~~~~~~~~~
@microbit-carlos
Copy link
Collaborator

I can confirm I get the same error when setting "dev": true in codal.json to checkout the latest commits.

@JohnVidler
Copy link
Collaborator

Apologies folks, I always end up enabling debug so forgot to guard against this. Will patch in a moment.

@JohnVidler
Copy link
Collaborator

Patched out as of lancaster-university/codal-core@ff91444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants