Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set LEVEL_DETECTOR_SPL_8BIT_000_POINT to 52.0 dB. #174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set LEVEL_DETECTOR_SPL_8BIT_000_POINT to 52.0 dB. #174

wants to merge 1 commit into from

Conversation

microbit-carlos
Copy link
Contributor

@microbit-carlos microbit-carlos commented Sep 17, 2024 •
edited
Loading

This is the value currently used by MakeCode:
https://github.com/microsoft/pxt-microbit/blob/v7.1.3/libs/microphone/microphone.cpp#L8

And MicroPython:
https://github.com/microbit-foundation/micropython-microbit-v2/blob/v2.1.2/src/codal_app/codal.json#L16

The reason to change it is that the LevelDetectorSPL() minValue default parameter is already 52:

codal-core/inc/streams/LevelDetectorSPL.h

Lines 123 to 126 in 509086c

LevelDetectorSPL(DataSource &source, float highThreshold, float lowThreshold, float gain,
float minValue = 52,
uint16_t id = DEVICE_ID_SYSTEM_LEVEL_DETECTOR_SPL,
bool activateImmediately = true);

MicroBitAudio also sets it to the same value 52.0:
https://github.com/lancaster-university/codal-microbit-v2/blob/v0.2.68/source/MicroBitAudio.cpp#L82

And LevelDetectorSPL will clamp as that being the min.

codal-core/source/streams/LevelDetectorSPL.cpp

Lines 142 to 147 in 509086c

if (conv < minValue)
level = minValue;
else if (isfinite(conv))
level = conv;
else
level = minValue;

Fixes lancaster-university/codal-microbit-v2#449.

@microbit-carlos
Set LEVEL_DETECTOR_SPL_8BIT_000_POINT to 52 dB.
1060835 
This is the value currently used by MakeCode:
https://github.com/microsoft/pxt-microbit/blob/v7.1.3/libs/microphone/microphone.cpp#L8

And MicroPython:
https://github.com/microbit-foundation/micropython-microbit-v2/blob/v2.1.2/src/codal_app/codal.json#L16

The reason to change it is that the LevelDetectorSPL() minValue
default parameter is already 52:
https://github.com/lancaster-university/codal-core/blob/509086cc8590465041b15493ab52b56e7071c110/inc/streams/LevelDetectorSPL.h#L124

MicroBitAudio also sets it to the same value:
https://github.com/lancaster-university/codal-microbit-v2/blob/v0.2.68/source/MicroBitAudio.cpp#L82

And LevelDetectorSPL will clamp as that being the min.
https://github.com/lancaster-university/codal-core/blob/509086cc8590465041b15493ab52b56e7071c110/source/streams/LevelDetectorSPL.cpp#L142-L147
@microbit-carlos microbit-carlos mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The value of LEVEL_DETECTOR_SPL_8BIT_000_POINT (32) will never be reached
1 participant
@microbit-carlos