-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concurrent create dataset gives bad error, doesn't retry #2403
Labels
bug
Something isn't working
Comments
Quick +1 to this, I have also experienced it. |
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If a user tries to append to the same dataset concurrently, one writer will fail with a confusing internal error:
This is because in
commit_new_dataset
, we don't retry to catch theCommitError::CommitConflict
:lance/rust/lance/src/io/commit.rs
Lines 126 to 138 in d8da445
For comparison, in
commit_transaction()
, we have a retry loop and a nicer error message:lance/rust/lance/src/io/commit.rs
Lines 486 to 494 in d8da445
We should change this to see if the transactions are compatible and, if so, have
commit_new_dataset
load the dataset and call intocommit_transaction
.The text was updated successfully, but these errors were encountered: