Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging modules with multiple components? #2

Open
hobofan opened this issue May 19, 2017 · 0 comments
Open

Packaging modules with multiple components? #2

hobofan opened this issue May 19, 2017 · 0 comments

Comments

@hobofan
Copy link
Member

hobofan commented May 19, 2017

The packager currently can only handle modules with a default export.

Mid-term it should be possible to also handle modules that have multiple exports, or where the only component is nested in a normal export (which can be a valid coding style decision).

Braindump:

  • It should also be possible to handle mulitple exports, where some of the exports are not Landau components. Maybe it's possible to detect if a export subclasses Landau.Component?
  • Should the default rendering be to render all possible components, or that one specific component always has to be selected? "All by default" feels like the right approach, but might present problems on the performance side. It might also not be too pretty if all the components are centered on the origin, so that would either produce a big blob of components at the origin or we would have to take an opinionated stance on how to show them in an "exploded" way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant