Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better memory usage from 800+ to 500+ #11796

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix: better memory usage from 800+ to 500+ #11796

merged 2 commits into from
Dec 20, 2024
+56 −26

Conversation

yihong0618
Copy link
Contributor

Summary

with this patch
image

without this patch

image

how to trace the memory

  1. use https://github.com/bloomberg/memray
  2. run memray run app.py and memray run app.py --debug
  3. read the flamegraph found some big memory are from some package like google and jieba
  4. lazy import them to better the memory usage and short the start time

flamegraph without this patch
image

flamegraph with this patch
image

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@yihong0618
fix: better memory usage from 800+ to 500+
e8b1156 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 18, 2024
@crazywoola crazywoola requested review from laipz8200 and takatost and removed request for laipz8200 December 18, 2024 09:36
@laipz8200 laipz8200 self-requested a review December 19, 2024 16:51
@yihong0618
fix: bring import handle back
27d2927 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@laipz8200
Copy link
Member

LGTM, does this PR ready to merge?

@yihong0618
Copy link
Contributor Author

My side is done maybe some other memory deduce can be a separate PR

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 20, 2024
@laipz8200 laipz8200 merged commit 7b03a03 into langgenius:main Dec 20, 2024
7 checks passed
@laipz8200
Copy link
Member

Great! Thank you!

jiangbo721 pushed a commit to jiangbo721/dify that referenced this pull request Dec 20, 2024
@yihong0618
fix: better memory usage from 800+ to 500+ (langgenius#11796)
8802d8b 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618 yihong0618 mentioned this pull request Jan 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laipz8200 laipz8200 laipz8200 approved these changes

@takatost takatost Awaiting requested review from takatost

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihong0618 @laipz8200