Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great Design and Implimentation. Found a small bug in design for profile. #11

Closed
shaheerkhan12 opened this issue Feb 23, 2024 · 2 comments

Comments

@shaheerkhan12
Copy link

I'm sure you already have seen this issue and you might be prioritizing other changes .Since its a small issue so i thought i should bring it to light.

When the user changes routes, The profile menu opens up after every route change and then closes. so it shows up and hides on every route change.

You can replicate it on your deployment by => going from dashboard to any auth component and then going back from there so
Dashboard > auth(i.e sign-in,sign-up) > going back to dashboard from browser .

A quick fix ,I made was i added an *ngIf over Profile-menu.component.html, worked for me.. maybe you have something better in mind
Good work! cheers
<div *ngIf="isMenuOpen" [ngClass]=" isMenuOpen ? 'pointer-events-auto scale-100 animate-fade-in-up opacity-100 duration-100' : 'pointer-events-none scale-95 opacity-0 duration-100 ease-in' "

@lannodev
Copy link
Owner

Hi @shaheerkhan12,
Thanks for sharing this problem. I think the best solution is to use angular animation.
I'll try to fix it in the next commit.

all the best.

@shaheerkhan12
Copy link
Author

yes, A firm solution would be angular animation. Looking forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants