Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken on tables at latest filament #14

Closed
dbpolito opened this issue Mar 5, 2024 · 5 comments · Fixed by #15
Closed

Broken on tables at latest filament #14

dbpolito opened this issue Mar 5, 2024 · 5 comments · Fixed by #15
Assignees
@atmonshi

Comments

@dbpolito
Copy link

dbpolito commented Mar 5, 2024

Hey man, love your work...

But it seems popover got broken on latest version, because of this PR:

filamentphp/filament#11524

image

Not sure it will be a good way of making it work besides reverting this on filament, for now i reverted the filament upgrade...
@dbpolito dbpolito changed the title Brokon on latest filament Broken on tables at latest filament Mar 5, 2024
@atmonshi
Copy link
Member

atmonshi commented Mar 5, 2024

thanks for the report, can you test this pr #15 if it worked?

@dbpolito
Copy link
Author

dbpolito commented Mar 5, 2024 •
edited
Loading

It's definitely looking better, but lost the ability for placement and offset:

before
image

after
image

I left a comment on PR too, i think it should be simple to fix

@atmonshi
Copy link
Member

atmonshi commented Mar 5, 2024

prefect will work on it tomorrow and release a new version

@atmonshi atmonshi self-assigned this Mar 5, 2024
@atmonshi atmonshi linked a pull request Mar 5, 2024 that will close this issue
fix popover in table #15
Merged
@atmonshi
Copy link
Member

atmonshi commented Mar 7, 2024

sorry for the delay, all done

@dbpolito
Copy link
Author

dbpolito commented Mar 7, 2024

thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atmonshi atmonshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix popover in table lara-zeus/popover
2 participants
@dbpolito @atmonshi