Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace DomPdf with a different library #1084

Closed
driesvints opened this issue Mar 5, 2021 · 5 comments
Closed

Replace DomPdf with a different library #1084

driesvints opened this issue Mar 5, 2021 · 5 comments
Labels
enhancement

Comments

@driesvints
Copy link
Member

Probably with Browsershot which will give us much more flexibility by using a true browser engine.
@driesvints driesvints added this to the v13 milestone Mar 5, 2021
@muarachmann
Copy link

Can I work on this @driesvints

@driesvints
Copy link
Member Author

I just saw Browsershot requires a node library. We probably don't want to force that upon our users so we'll need to either find a different library or settle for DOMPDF.

@driesvints driesvints removed this from the v13 milestone Apr 30, 2021
@driesvints
Copy link
Member Author

Gonna table this for now.

@arborrow
Copy link

arborrow commented Jul 7, 2022

@driesvints - Would CVE-2022-0085 be a good reason to re-open this issue? Peace - Anthony

@arborrow arborrow mentioned this issue Jul 7, 2022
Closed
@driesvints
Copy link
Member Author

Please see #1393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arborrow @driesvints @muarachmann