Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to get status property from non object #1239

Closed
mkuznik92 opened this issue Aug 20, 2021 · 1 comment · Fixed by #1240
Closed

Trying to get status property from non object #1239

mkuznik92 opened this issue Aug 20, 2021 · 1 comment · Fixed by #1240
Labels

Comments

@mkuznik92
Copy link

mkuznik92 commented Aug 20, 2021

  • Cashier Version: 13.4.4
  • Laravel Version: 8.45.1
  • PHP Version: 7.4
  • Database Driver & Version: Postgres 13.2

Description:

During Subscription item updateQuantity if Subscription hasSinglePrice (src/SubscriptionItem.php from line 118) I am getting error, that in $stripeSubscriptionItem->subscription->status, subscription is not and object. And that is true, because in stripe-php/lib/SubscriptionItem the property subscription is string type.

In the past I see, that there was no stripe_status update and I think it is unnecessary. Temporary I've made patch for my own purposes and it works fine.

patches.zip

Steps To Reproduce:

Try to fire $subscriptionItem->updateQuantity($value) for subscription with single price.

@driesvints
Copy link
Member

Thanks for reporting. I've sent in a PR to fix this: #1240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants