Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] add updateSource method #656

Closed
vladflip opened this issue Apr 25, 2019 · 2 comments
Closed

[Proposal] add updateSource method #656

vladflip opened this issue Apr 25, 2019 · 2 comments

Comments

@vladflip
Copy link

Current updateCard method creates a new card and leaves the old one intact. This was discussed in #282, but wasn't solved.

Having the new updateStripeCustomer method from #634, I would like to suggest creating an updateSource method or changing the way updateCard method works.

Stripe encourages using this way of updating a card:
https://stripe.com/docs/api/customers/update#update_customer-source
https://stripe.com/docs/recipes/updating-customer-cards#using-the-token-to-update-the-customers-card

Following the contribution guidelines, I created this issue before creating a pull request, however the implementation of the updateSource method is ready and you can check it here. I'm waiting for your review before I can make a pull request.

@driesvints
Copy link
Member

I'm going to have to say no because it's basically a one-liner which you can add to your own project. The current Stripe docs are also all disregarding making use of the current cards api because of the new SCA regulations coming up in September. We'll need to review all of this for v10 so I'm gonna hold off on this now.

@driesvints
Copy link
Member

Btw also see: #649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants