Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miss ConfirmPasswordController #30227

Closed
felipe-balloni opened this issue Oct 9, 2019 · 5 comments
Closed

Miss ConfirmPasswordController #30227

felipe-balloni opened this issue Oct 9, 2019 · 5 comments

Comments

@felipe-balloni
Copy link

  • Laravel Version: 6.2.0
  • PHP Version: 7.3.9

Description:

After update today, i'm getting the error:
ReflectionException::("Class App\Http\Controllers\Auth\ConfirmPasswordController does not exist")
//vendor/laravel/framework/src/Illuminate/Container/Container.php:804

I tink it's missing in PR #30214

Steps To Reproduce:

Just update to version 6.2.0 and use route:list

Thanks

@browner12
Copy link
Contributor

the ConfirmPasswordController is a userland file, it does not live in the Framework repository. You'll need to manually add it to your project.

You can copy it from the laravel/laravel repo here:

https://github.com/laravel/laravel/blob/master/app/Http/Controllers/Auth/ConfirmPasswordController.php

@felipe-balloni
Copy link
Author

Thanks to your help...

@jlaswell
Copy link

jlaswell commented Oct 10, 2019

re:Edit: In case anyone ever runs across this awkwardly. laravel/ui#36 (comment) 👍 🚀


Edit: I did some more digging and found laravel/ui#36 (comment). I'm sure my comment is now redundant and this is already on the radar.


Since this breaks applications following an update, there should at least be documentation under the upgrades section of the 6.x version.

I know with the move to v6, we've adopted Semantic Versioning and explicitly state that "minor and patch releases should never contain breaking changes." I think a PR to make this a opt-in is an nice workaround for a feature like this. What do you think about this sort of implementation, @driesvints?

As annoying as it may be, a patch version to fix compatibility should be applied to adhere to with Semantic Versioning.

@thejacer87
Copy link

sorry @jlaswell, im not following you. what happened in my repo that i needed to add this file?

@ghost
Copy link

ghost commented Oct 18, 2019

the ConfirmPasswordController is a userland file, it does not live in the Framework repository. You'll need to manually add it to your project.

You can copy it from the laravel/laravel repo here:

https://github.com/laravel/laravel/blob/master/app/Http/Controllers/Auth/ConfirmPasswordController.php

What next?
still same error just creating the file. I tried composer autodump but same result:

$ php artisan route:list

Illuminate\Contracts\Container\BindingResolutionException : Target class [App\Http\Controllers\Auth\ConfirmPasswordController] does not exist.

at /opt/.../vendor/laravel/framework/src/Illuminate/Container/Container.php:806
802|
803| try {
804| $reflector = new ReflectionClass($concrete);
805| } catch (ReflectionException $e) {

806| throw new BindingResolutionException("Target class [$concrete] does not exist.", 0, $e);
807| }
808|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants