[8.x] Schema Dump (MariaDB)

[mvdnbrk]

• Laravel Version: 8.x
• PHP Version: 7.4
• Database Driver & Version: 10.4.11-MariaDB

Description:

A schema:dump command is added in Laravel 8.x (PR #32275).
The baseDumpCommand uses --set-gtid-purged=OFF in the MySqlSchemaState class.

https://github.com/laravel/framework/blob/c389f0a4a0dfb411bf7f50edcf543a896299f73b/src/Illuminate/Database/Schema/MySqlSchemaState.php#L78-#L81

MariaDB does not have the --set-gtid-purged option which results in a ProcessFailedException.

Error Output:
mysqldump: unknown variable 'set-gtid-purged=OFF'

[taylorotwell]

This should be fixed.

[iKlsR]

Encountered this issue and just upgraded to 8.0, running latest MySQL 5.7

mysqldump: unknown variable 'set-gtid-purged=OFF'
mysqldump: unknown variable 'set-gtid-purged=OFF'

   Symfony\Component\Process\Exception\ProcessFailedException

  The command "mysqldump --set-gtid-purged=OFF --skip-add-drop-table --skip-add-locks --skip-comments --skip-set-charset --tz-utc --host="${:LARAVEL_LOAD_HOST}" --port="${:LARAVEL_LOAD_PORT}" --user="${:LARAVEL_LOAD_USER}" --password="${:LARAVEL_LOAD_PASSWORD}" "${:LARAVEL_LOAD_DATABASE}" --routines --result-file="${:LARAVEL_LOAD_PATH}" --no-data" failed.

Exit Code: 7(Unknown error)

Working directory: /app

Output:
================


Error Output:
================
mysqldump: unknown variable 'set-gtid-purged=OFF'

  at vendor/symfony/process/Process.php:252
    248▕      */
    249▕     public function mustRun(callable $callback = null, array $env = []): self
    250▕     {
    251▕         if (0 !== $this->run($callback, $env)) {
  ➜ 252▕             throw new ProcessFailedException($this);
    253▕         }
    254▕
    255▕         return $this;
    256▕     }

      +18 vendor frames
  19  artisan:37
      Illuminate\Foundation\Console\Kernel::handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

[Bouhnosaure]

Same here !

mysqldump: unknown variable 'set-gtid-purged=OFF'
mysqldump: unknown variable 'set-gtid-purged=OFF'

   Symfony\Component\Process\Exception\ProcessFailedException 

  The command "mysqldump --set-gtid-purged=OFF --skip-add-drop-table --skip-add-locks --skip-comments --skip-set-charset --tz-utc --host="${:LARAVEL_LOAD_HOST}" --port="${:LARAVEL_LOAD_PORT}" --user="${:LARAVEL_LOAD_USER}" --password="${:LARAVEL_LOAD_PASSWORD}" "${:LARAVEL_LOAD_DATABASE}" --routines --result-file="${:LARAVEL_LOAD_PATH}" --no-data" failed.

Exit Code: 7(Unknown error)

Working directory: /app

Output:
================


Error Output:
================
mysqldump: unknown variable 'set-gtid-purged=OFF'

  at vendor/symfony/process/Process.php:252
    248▕      */
    249▕     public function mustRun(callable $callback = null, array $env = []): self
    250▕     {
    251▕         if (0 !== $this->run($callback, $env)) {
  ➜ 252▕             throw new ProcessFailedException($this);
    253▕         }
    254▕ 
    255▕         return $this;
    256▕     }

      +18 vendor frames 
  19  artisan:37
      Illuminate\Foundation\Console\Kernel::handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

Client config :

root@592ea3c7e066:/app# mysqldump --version
mysqldump  Ver 10.17 Distrib 10.3.23-MariaDB, for debian-linux-gnu (x86_64)

[mvdnbrk]

@driesvints can this be reopened?

[mvdnbrk]

I am getting the following. probably related,

• Ver 15.1 Distrib 10.5.5-MariaDB
• Laravel 8.4

mysqldump: unknown variable 'column-statistics=0'

[taylorotwell]

Opne a PR to fix what you want.

[taylorotwell]

I have no idea if this works for MariaDB. I only use MySQL.

[driesvints]

@iKlsR are you using the latest Laravel version?

[iKlsR]

@driesvints Yes, latest everything. Fresh project and had just upgraded to 8.4 (1c57ab5) as well, php is 7.4, mysql 5.7.31. Running this with docker.

[mvdnbrk]

@iKlsR can you post the output of mysql --version ?

[iKlsR]

Pulled from https://hub.docker.com/r/bitnami/mysql/tags

$ lando mysql --version
mysql  Ver 14.14 Distrib 5.7.29, for Linux (x86_64) using  EditLine wrapper

Ah...

$ lando ssh
www-data@2a89f33458dc:/app$ mysqldump --version
mysqldump  Ver 10.17 Distrib 10.3.23-MariaDB, for debian-linux-gnu (x86_64)

Could a fix be to check the dump command version as well? https://bugs.mysql.com/bug.php?id=72312

[iKlsR]

Ok so poking around a bit, this seems to stem from the mariadb distrib. If I comment out the flag in baseDumpCommand() The schema gets dumped but then I run into #34303 so I guess that might warrant some looking at again as well.

Reading the entire issue listing with this as well as external fixes on this I propose stripping the flags --column-statistics=0 --set-gtid-purged=OFF if the dump version has mariadb or maybe entirely and allow access to the underlying dump executable to allow advanced? users to pass these. If I remove those works as expected and I don't think they are relevant either, you just want a schema dump.

[ludo237]

I don't have any issue at all with MariaDB 10.5.x and latest Laravel 8.