Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fixed type error #35956

Merged
merged 1 commit into from
Jan 20, 2021
Merged

[6.x] Fixed type error #35956

merged 1 commit into from
Jan 20, 2021

Conversation

GrahamCampbell
Copy link
Member

@GrahamCampbell GrahamCampbell commented Jan 20, 2021

Str::contains expects a string for the first param, not ?string. Passing null to this function will cause a crash if the Symfony mbstring polyfill is used, or if PHP 8.1+ is used.


Related: #35891, #35915, symfony/polyfill#329, https://bugs.php.net/bug.php?id=80649, https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg.

@taylorotwell taylorotwell merged commit d08fd80 into 6.x Jan 20, 2021
@taylorotwell taylorotwell deleted the fix branch January 20, 2021 13:50
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants