Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking custom validation messages not using translator has() function #53510

Closed
petrzpav opened this issue Nov 14, 2024 · 2 comments
Closed

Comments

@petrzpav
Copy link

Laravel Version

11

PHP Version

8.2

Database Driver & Version

No response

Description

The getCustomMessageFromTranslator function is using custom logic to check for translation messages instead of leveraging the translator's has() function.

This behavior causes an error when checking if a translation exists within the get function. Replacing this logic with the has() function would standardize the check and prevent such errors.

Reference: Laravel source

Steps To Reproduce

        $request->validate([
            'name' => 'required|string|max:255',
            'email' => 'required|email:rfc,dns|max:255|unique:users',
        ]);

Calling translator get() instead of translator has().

@crynobone
Copy link
Member

Hey there, thanks for reporting this issue.

We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here?

Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.

laravel new bug-report --github="--public"

Do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.

Thanks!

@crynobone
Copy link
Member

Hey there,

We're closing this issue because it's inactive, already solved, old, or not relevant anymore. Feel free to open up a new issue if you're still experiencing this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants