-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening the Filter Menu sometimes causes a refresh #6424
Comments
Please provide full reproducing repository based on fresh installation as suggested in the bug report template (or you can refer to https://github.com/nova-issues for example) |
I've created a repository for you, and I've linked a pull request (to my own repository) that shows you the files I added on top of the default Nova installation. I've also attached a video demonstrating the bug. |
crynobone
added
next
and removed
needs more info
More information is required
pending
Issues that are pending triage
labels
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
Opening the Filter Menu can cause a refresh when the backing value changes from a string to an integer, even if the value is effectively the same (e.g.
2
vs"2"
).Detailed steps to reproduce the issue on a fresh Nova installation:
Follow these steps:
Repository:
https://github.com/tylernathanreed/nova-issues/pull/1/files
Video:
Nova.6424.mp4
Root Cause
It took me awhile to figure this one out, but the root cause was the filter value changing from a string to an integer (e.g.
"2"
to2
). When a value is initially selected, the value ends up being a string. However, when the value is initialized from a string, theFilter/SelectField
component finds the option matching the string-based value, and assignsoption.value
tothis.value
, whereoption.value
was actually an integer.I was able to hack in a fix by modifying the source code for
Filter/SelectField
'swatch:selectedOption
function, and changingthis.value = option.value
tothis.value = String(option.value)
. There may be edge cases that need to be explored, but that solution definitely solved my problem.The text was updated successfully, but these errors were encountered: