Memory leak inside NamespacedItemResolver::parsed() cache when Octane is used

[zarikx]

• Laravel Version: 8.69.0
• PHP Version: 8.0.12
• Database Driver & Version: N/A

Description:

There are some caching mechanism inside \Illuminate\Support\NamespacedItemResolver::parseKey() method.
But this cache is never flushed when running Laravel Octane. This leads to some memory leak when many validation errors are being processed. It’s pretty easy to distinguish when attribute values are big enough.

Steps To Reproduce:

Using fresh install of Laravel Octane, you do something like this:

use Illuminate\Support\Facades\Route;
use Illuminate\Support\Facades\Validator;
use Illuminate\Support\Str;
use Illuminate\Validation\ValidationException;

Route::get('/', static function () {
    $data = ['name' => Str::random(65536)];

    $validator = Validator::make($data, [
        'name' => 'string|max:50',
    ]);

    try {
        $validator->validate();
    } catch (ValidationException) {
        info('exception', [
            'memory' => round(memory_get_usage() / 1024 / 1024, 4),
        ]);

        return 'error';
    }

    return 'ok';
});

Inside logs you can see that memory usage increases with every request:

[2021-11-04 16:19:30] local.INFO: exception {"memory":17.0533} 
[2021-11-04 16:19:30] local.INFO: exception {"memory":17.4827} 
[2021-11-04 16:19:31] local.INFO: exception {"memory":17.6159} 
[2021-11-04 16:19:32] local.INFO: exception {"memory":17.7491} 
[2021-11-04 16:19:32] local.INFO: exception {"memory":17.8826} 
[2021-11-04 16:19:32] local.INFO: exception {"memory":18.0158} 
[2021-11-04 16:19:33] local.INFO: exception {"memory":18.149} 
[2021-11-04 16:19:33] local.INFO: exception {"memory":18.2822} 
[2021-11-04 16:19:34] local.INFO: exception {"memory":18.4155} 
[2021-11-04 16:19:34] local.INFO: exception {"memory":18.5487

I did some performance testing without this cache, and I haven't seen any improvement, only within a margin of error.
Maybe we can consider deleting this caching to not overthink this issue?

[nunomaduro]

Working on it...

[foremtehan]

@zarikx thank you for reporting this important issue, i use a lot translator in my app

[nunomaduro]

This issue will be fixed on the next release.