Automatically disable worker mode in local environments if workers aren't specified explicitly #932
Conversation
…en't specified explicitly
|
Could we detect if XDebug is installed and only disable the worker mode if it is? It isn't by default and the worker mode improves performance even in dev mode. |
We could do
Still, that would require either using watch mode (which in turn demands node and chokidar, which makes setup more complex in e.g. Docker) or limiting the server to But @dunglas I respect if you want to approach this differently, and will close the PR—this is your domain. |
|
@Radiergummi a problem with this approach is that Xdebug can be disabled (or enabled) for the CLI SAPI (which, generally, isn't using FrankenPHP), but enabled (or disabled) for the FrankenPHP SAPI. It's rare when using Docker, but more common when not using it. Maybe would we store a tiny script detecting if Xdebug is enabled and run |
|
We'll need to fix the tests before continuing. |
…ankenPHP worker mode to avoid performance issues. See the discussion with Kévin Dunglas in the PR discussion for the reasoning: laravel#932 Essentially, disabling worker mode comes with performance drawbacks, but it's still the only sensible way to use FrankenPHP with XDebug. By automatically turning off worker mode if a) the amount of workers isn't set explicitly, b) we're running locally, and c) XDebug is not installed, or it's mode is set to "off", we get both optimal performance and XDebug working out of the box.
|
@dunglas sorry for only getting back to this now, things were a bit tense on my end lately. I just added a script as per your recommendation: Now, worker mode will be disabled if
That should work as discussed earlier, no? |
|
@Radiergummi What's the point of disabling worker mode locally when xdebug is off? For some applications, the difference is 50ms vs 300ms request times. Sure, we could just specify the workers explicitly (which we do), but I'm guessing most people don't do that. Plus, if we ever get automatic worker scaling in Franken, there would be no point in specifying the worker count explicitly through Octane, so even less people would actually be using I suggest just sticking with |
This PR updates the FrankenPHP configuration to disable worker mode if the application is running in the
localenvironment and the worker count is not specified explicitly (or set toauto).The problem
FrankenPHP's Worker mode keeps the application in memory, which does wonders for performance when running in production. Locally, however, it causes problems with XDebug, and does not reflect file changes immediately. The solution to the latter is configuring Octane to restart the worker after every request, thereby defeating most of the advantages of an application server in the first place.
The solution
By only enabling worker mode if the application is running in a non-local environment, it will be served in a CGI-like manner, i.e. what the built-in PHP server (used in
artisan serve) does—and exactly what you'd expect to happen: XDebug just works, and changes to files are reflected immediately.In production, worker mode will be enabled and all the benefits that come with it apply. We use the setup as provided in this PR in our production application and don't face any issues with it.
This solves dunglas/frankenphp#931, and probably solves #928 too.