Wildcard paths not working properly for file watcher

[binaryfire]

Octane Version

2.5.9

Laravel Version

11

PHP Version

8.3

What server type are you using?

Swoole

Server Version

8.3

Database Driver & Version

No response

Description

Wildcard paths like config/**/*.php in the watch array of config/octane.php aren't working properly.

Steps To Reproduce

1. Install chokidar
2. Run octane:start --watch (I'm using Swoole)
3. Modify a file in the config directory. Octane won't restart
4. Change config/**/*.php to config in the watch array of config/octane.php
5. Restart Octane server
6. Modify a file in the config directory. Octane will now correctly restart

Same problem with anything else using wildcards eg. database (try modifying a seeder to test).

[crynobone]

Shouldn't it be config/*.php?

[binaryfire]

@crynobone config/**/*.php is what's in the default config file:

octane/config/octane.php

Line 189 in 46a8499

'config/**/*.php',

But it should work either way. The ** pattern is supposed to match files in the root dir and all subdirs. It's probably more important for things like the public folder (public/**/*.php'). But as a side note, I seem to remember reading that config subdirectories are supported by the framework using dot notation.

The problem is reproducible with the default Octane config - you can test using any other directory in the array which uses ** in the path.

[binaryfire]

@crynobone Yeah looks config subdirs are supported, so config/**/*.php is the correct expression: https://laracasts.com/discuss/channels/laravel/laravel-8-put-config-files-in-a-subdirectory-of-config

[github-actions]

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!

[ChrisExP]

Chokidar removed support for glob in version 4.
They give suggestions for how to reproduce the functionality, but I don't know how that should work for Laravel Octane.
You can get it working by installing version 3 instead.

https://github.com/paulmillr/chokidar?tab=readme-ov-file#changelog