Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track typed value on Multiselect and Select #75

Closed
utsavsomaiya opened this issue Sep 19, 2023 · 12 comments
Closed

Track typed value on Multiselect and Select #75

utsavsomaiya opened this issue Sep 19, 2023 · 12 comments
Assignees

Comments

@utsavsomaiya
Copy link

Let's take one example:

image

Now I will down to the next page which is already PR pending. But when I type rather than the default is null at that time we will introduce search!!.

@utsavsomaiya
Copy link
Author

select-prompt.mp4

Here is the real-world use case!! I pressed version 5 then it will highlight 5.

@utsavsomaiya
Copy link
Author

When it's too large select the box rather than going down. It will become fast!!

@utsavsomaiya
Copy link
Author

utsavsomaiya commented Sep 19, 2023

Something like this:

select-prompt.mp4

@jessarcher
Copy link
Member

Hey @utsavsomaiya,

Thanks for the suggestion. This is something I've wanted to do from the beginning to make Prompts even more like web-based form inputs. I even thought that once you started typing letters, it could show a search field somewhere and then filter the list instead of just jumping to the first matching item, which would improve what the standard web-based form inputs do. I'm not sure where I would display the text input though as any increase in the prompt height can be jarring if the prompt is at the bottom of the terminal.

I'm also a little torn on how much we need it now that we have the search prompt and hopefully the multisearch prompt (#58), which are better for large lists.

This isn't a big priority for me at the moment, so it might be a while before I can look into it. I'm open to PRs as long as the UX feels right.

@utsavsomaiya
Copy link
Author

Okay... no worries @jessarcher .

I closed this issue.

@utsavsomaiya
Copy link
Author

@jessarcher Can we add password reveal functionality on password prompt?

@jessarcher
Copy link
Member

@utsavsomaiya how would you propose it's toggled on and off?

@utsavsomaiya
Copy link
Author

Get the key from the users or static any key. And when it's press it will be on ... next time it press it will be off.

@jessarcher
Copy link
Member

What key do you think would be a good default? And how would we let the user know the feature exists and how to toggle it?

I was thinking maybe an icon/button on the right (where the arrow currently appears on the suggest prompt), and you could press Tab to highlight it and Space to toggle it. Not sure, though.

@utsavsomaiya
Copy link
Author

Okay @jessarcher

I will make a PR. After you will suggest me. So its confirmed first with you. That's why we both understand the flow.

Thanks. ☺

@jessarcher
Copy link
Member

I can't make any promises about it getting accepted - it's ultimately up to Taylor. But if you really want the feature then it's worth having a go 🙂

@utsavsomaiya
Copy link
Author

I can't make any promises about it getting accepted - it's ultimately up to Taylor. But if you really want the feature then it's worth having a go 🙂

image

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants