Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Google Provider is compatible with Google Sign-in #337

Closed
driesvints opened this issue Feb 4, 2019 · 9 comments
Closed

Make sure Google Provider is compatible with Google Sign-in #337

driesvints opened this issue Feb 4, 2019 · 9 comments

Comments

@driesvints
Copy link
Member

Since the old Google Plus functionality is going to be deprecated we'll need to make sure that we can use the suggested alternative Google Sign-in instead.

New OAuth2 functionality: https://developers.google.com/identity/protocols/OAuth2
Shutdown notice: https://developers.google.com/+/api-shutdown

@No148
Copy link

No148 commented Feb 4, 2019

@driesvints I tried to migrate to google sign-in using version 3 of socialite. I read the documentation and found this notes https://developers.google.com/identity/sign-in/web/quick-migration-guide
I have a custom socialtite provider so I was able to override methods from standart providers of socialite.
I created new api keys google sign-in, disabled google+ api in console and it worked as usually.

@eaverdeja
Copy link

@No148 I'm not using a custom provider, but upgrading to 3.0.x-dev and changing the scopes seemed to work out for me. The Google+ API Dashboard stopped tracking the requests, so all seems fine. However, how can I be sure the migration was complete and correct?

@No148
Copy link

No148 commented Feb 4, 2019

@eaverdeja I don't really know for sure at the moment... I've changed api key and created a specific api key for google sign-in. (which was only possible from this page https://developers.google.com/identity/sign-in/web/sign-in) After using it I just have my fingers crossed... But everything seems to be working fine right now. I wish I knew more, mate!

@rajjanorkar
Copy link

  • Just pull 3.0.x-dev
  • No need to change anything in google developer console
  • No need to change/create new api key/secrete etc.
  • No other changes if you are not adding any additional scope (other than what package have)

It should just work fine.. i Tested it and it worked.

@cincauhangus
Copy link

how can i make this compatible with laravel 5.2.x?

@driesvints
Copy link
Member Author

@cincauhangus 5.2.x isn't supported anymore. Please upgrade to the latest version.

@Casperhr
Copy link

Any plans for a 2.x fix?

@driesvints
Copy link
Member Author

@Casperhr we actually pushed a 2.0 fix a couple of days ago. Use 2.0.x-dev to pull it in.

@driesvints
Copy link
Member Author

driesvints commented Feb 15, 2019

Friendly reminder to not rely on -dev versions too long and to upgrade your apps eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants