Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to record dumps even though the dump watcher tab is not open #1198

Closed
superDuperCyberTechno opened this issue Mar 8, 2022 · 2 comments

Comments

@superDuperCyberTechno
Copy link
Contributor

superDuperCyberTechno commented Mar 8, 2022

I propose that you add the option to record dumps regardless of whether or not the dump watcher tab is open in the Telescope interface.

This could be done by allowing the TELESCOPE_RECORD_DUMP_WATCHER_ALWAYS environment variable to control this outcome.

This can easily be achieved if we change L43 in DumpWatcher to the following:

if (! env('TELESCOPE_RECORD_DUMP_WATCHER_ALWAYS', false) && ! $this->cache->get('telescope:dump-watcher')) {
    return;
}
@driesvints
Copy link
Member

Feel free to attempt a PR 👍

@superDuperCyberTechno
Copy link
Contributor Author

superDuperCyberTechno commented Mar 8, 2022

Will do.

EDIT: #1199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants