You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Commands like valet use and valet install cause /*/local/etc/php/*/conf.d/php-memory-limits.ini to be overwritten, even if it already exists. Since this config file is loaded after php.ini, the directives override what users may have set in their php.ini files. In particular, this is a problem when running an application that requires a large amount of memory (e.g., Magento), and can especially be an issue in a CLI environment, where longer running commands might be run.
As a workaround, I've taken to creating a file like /*/local/etc/php/*/conf.d/zzz-final-config.ini to ensure I can overwrite config settings as needed. This works for now, but it would be better if Valet didn't unexpectedly overwrite config settings that I've changed manually. At the very least, it would be good to see a warning if Valet is changing config files underneath me.
Additionally, it would be nice to have a way to configure separate settings for CLI and FPM. I realize this part may be more on the package managers for the Homebrew PHP packages, though.
Steps To Reproduce:
Edit one of the /*/local/etc/php/*/conf.d/php-memory-limits.ini files.
Run valet install or valet use.
See that changes have been overwritten and the php-memory-limits.ini file is back to the default contents.
This discussion was converted from issue #1313 on December 08, 2022 14:30.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Description:
Commands like
valet use
andvalet install
cause/*/local/etc/php/*/conf.d/php-memory-limits.ini
to be overwritten, even if it already exists. Since this config file is loaded afterphp.ini
, the directives override what users may have set in theirphp.ini
files. In particular, this is a problem when running an application that requires a large amount of memory (e.g., Magento), and can especially be an issue in a CLI environment, where longer running commands might be run.As a workaround, I've taken to creating a file like
/*/local/etc/php/*/conf.d/zzz-final-config.ini
to ensure I can overwrite config settings as needed. This works for now, but it would be better if Valet didn't unexpectedly overwrite config settings that I've changed manually. At the very least, it would be good to see a warning if Valet is changing config files underneath me.Additionally, it would be nice to have a way to configure separate settings for CLI and FPM. I realize this part may be more on the package managers for the Homebrew PHP packages, though.
Steps To Reproduce:
/*/local/etc/php/*/conf.d/php-memory-limits.ini
files.valet install
orvalet use
.php-memory-limits.ini
file is back to the default contents.Diagnosis
N/A
Beta Was this translation helpful? Give feedback.
All reactions