Valet link with --isolate doesn't pass custom name #1386
Comments
|
I found the The --isolate switch does read the .valetrc file, but use it only for the isolation of the folders name, not the custom link "foobar" provided |
|
I think we have two separate issues. @naabster would you mind spinning up a separate issue for that? |
|
I made a tiny bit of progress but then had to leave earlier than expected. Here's what I did: cd /tmp
mkdir linking-as-not-foobar
cd linking-as-not-foobar
echo "php=php@8.0" > .valetrc
valet link foobar --isolateand here's my error:
So as we can see, we get this error when trying to isolate the directory: at /Users/mattstauffer/.composer/vendor/laravel/valet/cli/Valet/Site.php:182
Valet\Site->getSiteUrl() at /Users/mattstauffer/.composer/vendor/laravel/valet/cli/Valet/PhpFpm.php:171
Valet\PhpFpm->isolateDirectory() at /Users/mattstauffer/.composer/vendor/laravel/valet/cli/includes/facades.php:22It's passing in the directory instead of the isolated short name. Hopefully that's an easy fix when I have a bit more time! |
|
I'm new to Valet and I stumbled upon this exact issue. I organize my projects something like this: This incidentally results in the same issue: It took me a while to figure it out—given the many different ways Valet resolves sites—but the issue stems from the A simple solution to this: provide the if (Site::phpRcVersion($name)) {
- $this->runCommand('isolate');
+ $this->runCommand('isolate --site="'.$name.'"');
} else {Unfortunately, this does not work since mnapoli/silly v1.8.1 which introduced an untested change to how sub-commands are handled as a consequence of a easily confusing error message from symfony/console. See mnapoli/silly#69 for further details, mnapoli/silly#70 for the fix of the dependency, and laravel/valet#1428 for the fix of this issue. |
|
Will be in today's release. Thanks all |
Description:
When running
valet link --isolatewith a custom name that doesn't match the directory name, such asvalet link foobar --isolate, where the directory the site is in may be foobar.com, the isolate command doesn't seem to receive the custom name and ends up failing with the following validation error.Steps To Reproduce:
valet link --isolate foobarDiagnosis
sw_vers
valet --version
cat ~/.config/valet/config.json
{ "tld": "test", "loopback": "127.0.0.1", "paths": [ "/Users/chrisware/.config/valet/Sites" ] }cat ~/.composer/composer.json
{ "require": { "beyondcode/expose": "^2.2", "laravel/envoy": "^2.8", "laravel/forge-cli": "^1.3", "laravel/installer": "^4.2", "laravel/pint": "^1.1", "laravel/valet": "^4.0", "statamic/cli": "^2.4", "tightenco/takeout": "^2.1" }, "config": { "allow-plugins": { "ergebnis/composer-normalize": true }, } }composer global diagnose
composer global outdated
ls -al /etc/sudoers.d/
brew config
brew services list
brew list --formula --versions | grep -E "(php|nginx|dnsmasq|mariadb|mysql|mailhog|openssl)(@\d\..*)?\s"
brew outdated
brew tap
php -v
PHP 8.2.3 (cli) (built: Feb 15 2023 00:58:03) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.3, Copyright (c) Zend Technologies with Zend OPcache v8.2.3, Copyright (c), by Zend Technologieswhich -a php
php --ini
nginx -v
curl --version
php --ri curl
/opt/homebrew/bin/ngrok version
ls -al ~/.ngrok2
brew info nginx
brew info php
==> php: stable 8.2.4 (bottled), HEAD General-purpose scripting language https://www.php.net/ /opt/homebrew/Cellar/php/8.1.12 (193 files, 33.8MB) Built from source /opt/homebrew/Cellar/php/8.2.3 (519 files, 83.3MB) * Poured from bottle on 2023-02-15 at 12:37:35 From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/php.rb License: PHP-3.01 ==> Dependencies Build: httpd, pkg-config Required: apr, apr-util, argon2, aspell, autoconf, curl, freetds, gd, gettext, gmp, icu4c, krb5, libpq, libsodium, libzip, oniguruma, openldap, openssl@1.1, pcre2, sqlite, tidy-html5, unixodbc ==> Options --HEAD Install HEAD version ==> Caveats To enable PHP in Apache add the following to httpd.conf and restart Apache: LoadModule php_module /opt/homebrew/opt/php/lib/httpd/modules/libphp.soFinally, check DirectoryIndex includes index.php
DirectoryIndex index.php index.html
The php.ini and php-fpm.ini file can be found in:
/opt/homebrew/etc/php/8.2/
To start php now and restart at login:
brew services start php
==> Analytics
install: 16,191 (30 days), 311,161 (90 days), 1,416,631 (365 days)
install-on-request: 14,342 (30 days), 275,954 (90 days), 1,232,465 (365 days)
build-error: 0 (30 days)
brew info openssl
openssl version -a
openssl ciphers
sudo nginx -t
which -a php-fpm
/opt/homebrew/opt/php/sbin/php-fpm -v
PHP 8.2.3 (fpm-fcgi) (built: Feb 15 2023 00:58:04) Copyright (c) The PHP Group Zend Engine v4.2.3, Copyright (c) Zend Technologies with Zend OPcache v8.2.3, Copyright (c), by Zend Technologiessudo /opt/homebrew/opt/php/sbin/php-fpm -y /opt/homebrew/etc/php/8.2/php-fpm.conf --test
ls -al ~/Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchDaemons | grep homebrew
ls -al /Library/LaunchDaemons | grep "com.laravel.valet."
ls -aln /etc/resolv.conf
cat /etc/resolv.conf
ifconfig lo0
sh -c 'echo "------\n/opt/homebrew/etc/nginx/valet/valet.conf\n---\n"; cat /opt/homebrew/etc/nginx/valet/valet.conf | grep -n "# valet loopback"; echo "\n------\n"'
sh -c 'for file in ~/.config/valet/dnsmasq.d/*; do echo "------\n~/.config/valet/dnsmasq.d/$(basename $file)\n---\n"; cat $file; echo "\n------\n"; done'
The text was updated successfully, but these errors were encountered: