Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping CJS support #234

Closed
benmccann opened this issue Aug 4, 2023 · 1 comment · Fixed by #235
Closed

Dropping CJS support #234

benmccann opened this issue Aug 4, 2023 · 1 comment · Fixed by #235

Comments

@benmccann
Copy link
Contributor

benmccann commented Aug 4, 2023 •
edited
Loading

Vite would like to drop CJS support, which means this project will need to. The documentation already uses ESM and I only found four projects that require the laravel-vite-plugin, so this should barely affect anyone. Is this a change we can go ahead and make or are there other things we should consider or that you have questions about?

I've sent PRs or files issues to migrate all the projects I could find:
@benmccann benmccann mentioned this issue Aug 4, 2023
Merged
@timacdonald
Copy link
Member

Closing this and we can follow along with the PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[1.0] Drop CJS build and export types first benmccann/vite-plugin
2 participants
@benmccann @timacdonald