Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Review codebase #1

Open
dallas opened this issue Feb 15, 2012 · 4 comments
Open

Review codebase #1

dallas opened this issue Feb 15, 2012 · 4 comments

Comments

@dallas
Copy link
Collaborator

dallas commented Feb 15, 2012

  • Is it Rails 3.0 compatible?
    • Rails 3.1?
    • Rails 3.2?
  • Is it meant to only be compatible with Rails (or at least ActiveRecord)—could it support other ORMs?
  • Are any video connection adapters out of date?
    • Can they be updated?
  • Are there any new ones that can be added?
    • How's that Hulu public API coming along?
  • How's testing and code coverage?
@laserlemon
Copy link
Owner

I'm thinking a complete teardown may be in order here, starting on a new, clean master and archiving (quarantining) current master to another branch.

@laserlemon
Copy link
Owner

Decided against it. Starting work on master. I'd like to make a significant change. I don't want to have 3 columns for each video attribute. All of a video's information should be serializable into one column that shares its name with the video attribute.

I've been toying with the idea of a separate gem to do the serialization and I think this will be the push to build that. I started a repo at laserlemon/capital. The purpose will be to pull rich objects our of the database, rather than simple strings, integers, etc. ActiveRecord's serialization doesn't quite cut it in my mind because it seems you have to feed it the rich object. I want the attribute to take a string (video URL) and infer the rich object on the fly. Capital will pretty closely mimic how MongoMapper does its serialization with the from_mongo and to_mongo methods.

@dallas
Copy link
Collaborator Author

dallas commented Feb 15, 2012

Hmm…I didn't even realize that it currently required 3 columns. I thought it was serialized and composed of using that serialize data. I'll have to look at how from_mongo and to_mongo work for MongoMapper to see what you mean and where you're heading with this "capital" project.

@dallas
Copy link
Collaborator Author

dallas commented Feb 15, 2012

Could we do something more like Carrierwave does where we just store the original URL as a simple string column and let the Videoclip class handle which video service/host it is and what the video’s unique identifier is on the fly…every time it's pulled out of the database and used? Would that be too much overhead or would it need to contact those services in some way every single time to get any of that information?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants