Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialize in all HF model parsers to take in model id from data param #822

Open
rossdanlm opened this issue Jan 9, 2024 · 2 comments

Comments

@rossdanlm
Copy link
Contributor

rossdanlm commented Jan 9, 2024

Ankush pointed out that we're passing in the model parser id instead of the model id, which will cause serialize() to crash: https://github.com/lastmile-ai/aiconfig/blob/main/extensions/HuggingFace/python/src/aiconfig_extension_hugging_face/local_inference/text_2_image.py#L229

Instead we should be passing in the model from the data param and using that: https://github.com/lastmile-ai/aiconfig/blob/main/python/src/aiconfig/default_parsers/openai.py#L86

We should also be building automated testing for serialize (similar to Dall-E) so that we don't run into this issue again

@rossdanlm rossdanlm added type: bug Something isn't working good first issue Good for newcomers pri: mid effort: mid status: backlog and removed good first issue Good for newcomers labels Jan 9, 2024
@rossdanlm
Copy link
Contributor Author

Similarly, should support the "model" param arg for deserialize(): #883 (comment)

@rossdanlm
Copy link
Contributor Author

Note that ASR call supports model param: #883 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant